Skip to content

Conversation

@cibere
Copy link
Contributor

@cibere cibere commented Nov 23, 2024

Basically just adds a notification that gets shown when the plugin's initialize method is called

@jjw24
Copy link
Member

jjw24 commented Nov 23, 2024

Hey @cibere, what are the use cases for this plugin?

@cibere
Copy link
Contributor Author

cibere commented Nov 23, 2024

Hey @cibere, what are the use cases for this plugin?

I'm not sure about others, but I find it really annoying to have to guess when flow launcher is done loading or restarting, so i end up spamming my keybind until it shows up. I also have the flow launcher tray icon hidden because i use my tray icons a lot, and would find it even more annoying to either have an extra icon i won't use or have to drag flow's icon to the overflow menu.

This plugin doesn't need to be added to the manifest, I'm ok with it just being a local plugin for me, I just thought I'd create a PR anyways

@jjw24
Copy link
Member

jjw24 commented Nov 24, 2024

This plugin doesn't need to be added to the manifest, I'm ok with it just being a local plugin for me, I just thought I'd create a PR anyways

No it's fine, happy to add. I was asking because I wasn't sure if this is something we can fix on flow's side or this plugin is sufficient to fill that void.

Does it notifies only when the plugin finishes loading or when all plugins have finished?

@cibere
Copy link
Contributor Author

cibere commented Nov 24, 2024

Does it notifies only when the plugin finishes loading or when all plugins have finished?

It just notifies you when flow sends the plugin the initialize request, which for me at least, gives me a better idea as to when flow will be ready (in my testing, flow was normally ready 1-3 seconds after the notification depending on the other installed plugins

@jjw24 jjw24 merged commit 8104fba into Flow-Launcher:plugin_api_v2 Nov 24, 2024
5 checks passed
@jjw24
Copy link
Member

jjw24 commented Nov 24, 2024

Oh ok so it notifies once this plugin's initialize has finished but there could be other plugins still initialising.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants